Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iam_role - makes EntityAlreadyExists error a warning and fixes bug when not creating a profile #2282

Merged
merged 1 commit into from
Sep 4, 2024
Merged

iam_role - makes EntityAlreadyExists error a warning and fixes bug when not creating a profile #2282

merged 1 commit into from
Sep 4, 2024

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Sep 4, 2024

fixes: #2102
fixes: #2281

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

iam_role

ADDITIONAL INFORMATION

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@tremble tremble added the backport-8 PR should be backported to the stable-8 branch label Sep 4, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6b09a483609b4cd8987cedc2e9dded01

✔️ ansible-galaxy-importer SUCCESS in 8m 14s
✔️ build-ansible-collection SUCCESS in 10m 34s
✔️ ansible-test-splitter SUCCESS in 4m 16s
✔️ integration-amazon.aws-1 SUCCESS in 7m 35s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Sep 4, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/fc8474918dff494eb578bd6c560d8e60

✔️ ansible-galaxy-importer SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 10m 29s
✔️ ansible-test-splitter SUCCESS in 4m 15s
✔️ integration-amazon.aws-1 SUCCESS in 10m 14s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 4867e68 into ansible-collections:main Sep 4, 2024
37 checks passed
@patchback Patchback
Copy link

patchback bot commented Sep 4, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/4867e6876f85ef0184bc587927ab247871cf5899/pr-2282

Backported as #2283

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 4, 2024
@tremble @patchback
iam_role - makes EntityAlreadyExists error a warning and fixes bug wh…
f0ce9e9 
…en not creating a profile (#2282)

fixes: #2102
fixes: #2281
SUMMARY

#2221 deprecation logic accidentally forced create_instance_profile to True
The IAM refactor made iam_role sensitive to pre-existing instance profiles with the same name.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_role
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis
Reviewed-by: GomathiselviS
(cherry picked from commit 4867e68)
@patchback patchback bot mentioned this pull request Sep 4, 2024
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Sep 4, 2024
@patchback
iam_role - makes EntityAlreadyExists error a warning and fixes bug wh…
689024f 
…en not creating a profile (#2282) (#2283)

This is a backport of PR #2282 as merged into main (4867e68).
fixes: #2102
fixes: #2281
SUMMARY

#2221 deprecation logic accidentally forced create_instance_profile to True
The IAM refactor made iam_role sensitive to pre-existing instance profiles with the same name.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
iam_role
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@GomathiselviS GomathiselviS GomathiselviS approved these changes

Assignees
No one assigned
Labels
backport-8 PR should be backported to the stable-8 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
3 participants
@tremble @alinabuzachis @GomathiselviS